[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V5] xen/privcmd.c: improve performance of MMAPBATCH_V2.
On Thu, 2012-12-20 at 10:40 +0000, Ian Campbell wrote: > I've added Andres since I think this accumulation of ENOENT in err_ptr > is a paging related thing, or at least I think he understands this > code ;-) > > > @@ -89,37 +89,112 @@ static int remap_pte_fn(pte_t *ptep, pgtable_t token, > > unsigned long addr, > > struct page *page = info->pages[info->index++]; > > unsigned long pfn = page_to_pfn(page); > > pte_t pte = pfn_pte(pfn, info->prot); > > - > > - if (map_foreign_page(pfn, info->fgmfn, info->domid)) > > - return -EFAULT; > > + int err; > > + // TODO: We should really batch these updates. This just made me realise that we need a way for XENMEM_add_to_physmap_range to return errors for each slot. I'll look into that in the new year. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |