Re: [Xen-devel] [PATCH 03 of 10 v2] xen: sched_credit: let the scheduler know about node-affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2012-12-21 at 14:29 +0000, George Dunlap wrote: 
> > Sorry for that, I probably spent so much time buried, as you where
> > saying, in the
> > various nested loops and calls, that I lost the context a little bit! :-P
> 
> OK, that makes sense -- I figured it was something like that.  Don't 
> feel too bad about missing that connection -- we're all fairly blind to 
> our own code, and I only caught it because I was trying to figure out 
> what was going on.
>
Yeah, thanks, and no, I won't let this let me down to much, Even if this
was quite a big one. After all, that's what we have patch review for!

> That's why we do patch review. :-)
> 
Hehe, I see we agree. :-)

> Honestly, the whole "steal work" idea seemed a bit backwards to begin 
> with, but now that we're not just dealing with "possible" and "not 
> possible", but with "better" and "worse", the work-stealing method of 
> load balancing sort of falls down.
>
> [snip]
> 
> But that's kind of a half-baked idea at this point.
> 
Yes, this whole stealing work machinery may be rethought a bit. However,
let's get something sane in re NUMA load balancing ASAP, as we planned,
and then we'll see whether/how to rework it with both simplicity and
effectiveness in mind.

> > Ok, I think the problem I was describing is real, and I've seen it 
> > happening and
> > causing performances degradation. However, as I think a good solution
> > is going to
> > be more complex than I thought, I'd better repost without this
> > function and deal with
> > it in a future separate patch (after having figured out the best way
> > of doing so). Is
> > that fine with you?
> 
> Yes, that's fine.
>
Ok, I'll sort out all your comments and try to post v3 in early January,
so that you'll find it in your inbox as soon as you'll be back from
vacations! :-)

>   Thanks, Dario.
> 
Thanks to you,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel