[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 08/10] nEPT: handle invept instruction from L1 VMM



>>> On 04.01.13 at 01:57, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> wrote:
>> >
>> > +int nvmx_handle_invept(struct cpu_user_regs *regs) {
>> > +    struct vmx_inst_decoded decode;
>> > +    unsigned long eptp;
>> > +    u64 inv_type;
>> > +
>> > +    if ( decode_vmx_inst(regs, &decode, &eptp, 0) != X86EMUL_OKAY )
>> > +        return X86EMUL_EXCEPTION;
>> 
>> So in the overview you said you fixed this, but here it is again:
>> There are more than the two X86EMUL_* values referenced above, and
>> hence you can't imply that if it's not one, it's the other.
> 
> Do you mean X86EMUL_EXCEPTION can't be returned here ?

No - I'm trying to tell you that you should return whatever
decode_vmx_inst() returned.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.