Re: [Xen-devel] [PATCH] Switch from select() to poll() in xenconsoled's IO loop

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-01-08 at 14:01 +0000, Mats Petersson wrote:
> >> +struct pollfd *xs_pollfd;
> Why is this not "static"?
> >> +static struct pollfd  *fds;
> >> +static unsigned int current_array_size;
> >> +static unsigned int nr_fds;
> There seems to be no particular reason why these variables are here, and 
> the other ones up the top of the file. For example xce_handle is not 
> used "above" here, but it's declared at the top of the file. I think 
> keeping all variables together makes more sense than scattering them around.

I'd prefer if those which can be were local to the handle_io function
and not global at all.  I think this includes both xs_pollfd and
xce_pollfd.

I think it also includes the existing xce_handle and log_hv_evtchn.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel