[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 3/3] Implement 3-level event channel routines.



On Thu, 2013-01-03 at 11:35 +0000, Jan Beulich wrote:
> >>> On 31.12.12 at 19:22, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> >
> > +static void __unmap_l2_sel(struct vcpu *v)
> > +{
> > +    unsigned long mfn;
> > +
> > +    if ( v->evtchn_pending_sel_l2 != 0 )
> > +    {
> > +        unmap_domain_page_global(v->evtchn_pending_sel_l2);
> > +        mfn = virt_to_mfn(v->evtchn_pending_sel_l2);
> 
> virt_to_mfn() is not valid on the output of
> map_domain_page{,_global}() (same further down). Yes, there is
> at least one example of this in the existing code, but that's wrong
> too, and is getting eliminated by the 16Tb patch series I'm in the
> process of putting together.
> 

So what's the correct way to do this? Do I need to wait for your patch
series?


Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.