Re: [Xen-devel] [PATCH 7 of 7 v2] blktap3/tapback: Introduce tapback daemon Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-01-04 at 12:14 +0000, Thanos Makatos wrote:
> This patch introduces the Makefile that builds the tapback daemon. This
> Makefile is not yet hooked into the build system.

At this point could I run make -C tools/blktap3/tapback and expect
something useful to happen? (Assuming I'd done the same for the
necessary prerequisite subdirs already).

> diff -r 407ebde55295 -r 84f9d3e16cf1 tools/blktap3/tapback/Makefile
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/tools/blktap3/tapback/Makefile  Fri Jan 04 12:10:40 2013 +0000
> @@ -0,0 +1,48 @@
> +XEN_ROOT := $(CURDIR)/../../../
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +BLKTAP_ROOT := ..
> +
> +INST_DIR ?= /usr/bin

Please use whichever of the existing $(FOO_DIR) is relevant.

> +
> +IBIN = tapback
> +
> +# -D_GNU_SOURCE is required by vasprintf.
> +override CFLAGS += \
> +     -I$(BLKTAP_ROOT)/include \
> +     -I$(BLKTAP_ROOT)/control \
> +     -D_GNU_SOURCE \
> +    $(CFLAGS_libxenstore) \
> +    $(CFLAGS_libxenctrl) \
> +     $(CFLAGS_xeninclude) \
> +    -Wall \
> +    -Wextra \
> +    -Werror

Whitespace is all messed up here.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel