Re: [Xen-devel] [RFC PATCH V2 07/14] Genneralized event channel operations

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.13 at 15:30, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> +static struct xen_evtchn_ops __read_mostly xen_evtchn_ops_l2 = {

"const" instead of "__read_mostly".

> +    .set_pending      = evtchn_set_pending_l2,
> +    .clear_pending    = evtchn_clear_pending_l2,
> +    .unmask           = evtchn_unmask_l2,
> +    .is_pending       = evtchn_is_pending_l2,
> +    .is_masked        = evtchn_is_masked_l2,
> +};
> @@ -1272,7 +1302,6 @@ void evtchn_move_pirqs(struct vcpu *v)
>      spin_unlock(&d->event_lock);
>  }
>  
> -
>  static void domain_dump_evtchn_info(struct domain *d)
>  {
>      unsigned int port;
> @@ -1334,6 +1363,7 @@ static void domain_dump_evtchn_info(struct domain *d)
>      spin_unlock(&d->event_lock);
>  }
>  
> +
>  static void dump_evtchn_info(unsigned char key)
>  {
>      struct domain *d;

Stray newline adjustments?

> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -69,6 +69,7 @@ extern struct domain *dom0;
>  
>  #define EVTCHNS_PER_BUCKET 512
>  #define NR_EVTCHN_BUCKETS  (NR_EVENT_CHANNELS / EVTCHNS_PER_BUCKET)
> +struct xen_evtchn_ops;

No need to forward declare this here.

>  
>  struct evtchn
>  {
> @@ -279,6 +280,7 @@ struct domain
>      struct evtchn  **evtchn;
>      spinlock_t       event_lock;
>      unsigned int     evtchn_level;
> +    struct xen_evtchn_ops *eops;
>  
>      struct grant_table *grant_table;

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel