Re: [Xen-devel] [PATCH RFC 02/10] libxl: add new hotplug interface support to hotplug script callers

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 18/01/13 14:29, Ian Campbell wrote:
>> diff --git a/tools/libxl/libxl_netbsd.c b/tools/libxl/libxl_netbsd.c
>> index 9587833..8061e7a 100644
>> --- a/tools/libxl/libxl_netbsd.c
>> +++ b/tools/libxl/libxl_netbsd.c
>> @@ -62,7 +62,7 @@ out:
>>  int libxl__get_hotplug_script_info(libxl__gc *gc, libxl__device *dev,
>>                                     char ***args, char ***env,
>>                                     libxl__device_action action,
>> -                                   int num_exec)
>> +                                   int num_exec, int hotplug_version)
> 
> Is it worth wrapping verison and action into a little
> libxl__hotplug_action struct? 

I'm going to pack hotplug_version and num_exec inside a
libxl__hotplug_action struct, but not device_action, because
device_action is not only used by hotplug scripts, it is also used by
the general device connection/disconnection flow, and it will be strange
to put it inside a hotplug specific struct.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel