Re: [Xen-devel] [RFC PATCH 10/16]: PVH xen: introduce vmx_pvh.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.01.13 at 02:59, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Tue, 15 Jan 2013 08:46:35 +0000 "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> The main thing are the hypercall wrappers - they're definitely not
>> VMX-specific, and hence don't belong in VMX-specific code. Besides
> 
> Ah, I see. The HVM hcalls are in hvm.c and not vmx.c. Since PVH needs
> slightly different hcalls and restricts certain ones ok for HVM, I really
> prefer to not pollute hvm_do_hypercall() with if PVH everywhere. I could
> add a new function to hvm.c, pvh_hvm_do_hypercall(), or create a new
> file hvm_pvh.c and add it there. What would you suggest?

The only mail with that patch that I have definitely has these in
xen/arch/x86/hvm/vmx/vmx_pvh.c.

So yes, the correct thing - if adjustments to the existing ones
makes the code too ugly - would be for them to go into
xen/arch/x86/hvm/pvh.c.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel