Re: [Xen-devel] [PATCH v2 1/4] xen: move XEN_SYSCTL_physinfo, XEN_SYSCTL_numainfo and XEN_SYSCTL_topologyinfo to common code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-01-16 at 18:58 +0000, Stefano Stabellini wrote:
> @ -93,9 +93,9 @@ int __init init_xen_time(void)
>      if ( (READ_CP32(ID_PFR1) & ID_PFR1_GT_MASK) != ID_PFR1_GT_v1 )
>          panic("CPU does not support the Generic Timer v1 interface.\n");
> 
> -    cntfrq = READ_CP32(CNTFRQ);
> +    cpu_khz = READ_CP32(CNTFRQ) / 1000;

Does the loss of precision here matter in practice? Would we be better
off sticking with cntfrq and doing the divide in arch_do_physinfo?

> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index 4ed5df6..96b36c2 100644
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -136,6 +136,9 @@ extern unsigned long frametable_base_mfn;
> 
>  extern unsigned long max_page;
>  extern unsigned long total_pages;
> +/* XXX: implement NUMA support */
> +#define node_spanned_pages(nid)        (total_pages)
> +#define __node_distance(a, b) (20)

Please put these in asm-arm/numa.h



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel