Re: [Xen-devel] [RFC PATCH 10/16]: PVH xen: introduce vmx_pvh.c

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 24 Jan 2013 16:31:22 +0000
Tim Deegan <tim@xxxxxxx> wrote:

> At 18:01 -0800 on 11 Jan (1357927270), Mukesh Rathor wrote:
> That's a bit risky: EXIT_REASON_EXCEPTION_NMI includes a lot of cases
> that might not be safe to handle with interrupts disabled.  Also I
> think it means there are paths through this function that don't
> enable irqs at all.
> 
> I think it'd be better to do it the way vmx_vmexit_handler() does:
> explicitly sort out the things that _must_ be done with irqs disabled
> first, so it's clear which code runs with irqs enabled and which
> doesn't.

Yup, fixed already.

> This is a hard tab.  Actually, the whitespace in this file needs
> attention generally.

rats, i turn tab on when making linux changes, and then on xen side
sometimes forget to turn them off. anyways, fixed.

thanks,
mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel