Re: [Xen-devel] [RFC PATCH 1/15]: PVH xen: turn gdb_frames/gdt_ents into union

[Tim Deegan <tim@xxxxxxx>]

At 18:04 -0800 on 24 Jan (1359050661), Mukesh Rathor wrote:
> Initially, I had it called gdt, but during code review of linux
> patch (exact same change there), it was suggested to change it.

Huh.  Fair enough, I guess.

> Also, I really dont' like field names likes "addr" or "sz". I really
> don't wanna grep or cscope for them.

I'm fairly strongly in the other camp -- I almost never find myself
grepping for leaf-node names, but having unions called 'u' and repeating
type or scope information in names both annoy the crap out of me. :)

Anyway, it seems like Jan agrees with you on the naming, so I'll let it
slide.  Can I suggest you call the new fields gdt_addr and gdt_sz, to
match the underscores in the existing fields?

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel