Re: [Xen-devel] [PATCH v2] Fix scheduler crash after s3 resume

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.01.13 at 11:18, Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx> 
>>> wrote:

>> But you neglect the fact that waking vCPU-s at this point is
>> unnecessary anyway (they have nowhere to run on).
>>    
> Hm, can't they still run on cpu 0?

They could, but there's no point in even trying to before having
thawed domains.

> Also, I did earlier try to patch this 
> more primitively by adding a check to vcpu_wake whether the cpu is in 
> cpu_online_map, and whilst it stopped the crashing, I observed some 
> unexpected hangs w/o any serial output - sometimes just the dom0 would 
> hang, sometimes also xen would stop being responsive on serial. So I 
> figured out that these missed vcpu wakes account for something still.

Oh, yes, of course, keeping vcpu_wake() from doing its job
like this is surely calling for other problems.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel