Re: [Xen-devel] [PATCH] tools: revert to using /var and /etc/

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Monday, January 28, 2013, 11:25:38 AM, you wrote:

> On Sun, 2013-01-27 at 21:49 +0000, Sander Eikelenboom wrote:
>> Friday, January 25, 2013, 5:15:24 PM, you wrote:
>> 
>> > On Fri, 2013-01-25 at 13:41 +0000, Roger Pau Monne wrote:
>> >> On 25/01/13 14:10, Ian Campbell wrote:
>> >> > 26470:acaf29203cf9 "tools+stubdom: install under /usr/local by
>> >> > default" moved more stuff under /usr/local than was desirable.
>> >> > 
>> >> > In particular SYSCONFIG_DIR (configuration for initscripts) moved to
>> >> > /usr/local/etc/{sysconfig,defaults} while the initscripts themselves
>> >> > (correctly) remained in /etc/init.d. Moving /etc/xen/scripts breaks
>> >> > the udev bakcned rules file. Lastly stuff under /var was moved to
>> >> > /usr/local/var.
>> >> > 
>> >> > Move these back to /etc/ and /var. Moving /etc wholesale rather thsn
>> >> > just the problematic bits is preferable for consistency.
>> >> > 
>> >> > Although there seems to be some disagreement about /usr/local/var vs
>> >> > /var using /var is compatible with the FHS and what we think most
>> >> > people will expect.
>> >> > 
>> >> > Most of this impacts Linux only but NetBSD appears to have been using
>> >> > /usr/local/var/lib which I have also reset to /var/lib.
>> >> > 
>> >> > Note that we already paid no attention to autoconf --sysconfdir or
>> >> > --localstatedir ('etc' and 'var' respectively) so there is no change
>> >> > from that PoV.
>> >> > 
>> >> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >> > Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>
>> >> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxx?
>> >> Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
>> 
>> > Applied, thanks.
>> 
>> Hmm all the initscripts and the SYSCONFIG_DIR scripts still have
>> hardcoded paths to /usr/bin or /usr/sbin in them.

> Oh, so they do :-(

It's also a mix with absolute paths, and no paths.

Another thing is that:
        $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic -M xenpv 
-daemonize -monitor /dev/null -pidfile $QEMU_PIDFILE

Doesn't seem to start with upstream qemu, combination of -nographic and 
-daemonize doesn't seem to be allowed anymore.
(not a problem for me, because i don't seem to be using it as diskbackend, but 
for a 4.3 release ...)

>> Changed them by hand for the moment, but still no succes booting.
>> Perhaps there are some more places where paths are hardcoded and not
>> derived from the result of ./configure ?

> It does seem likely :-/

> I think at this point we should revert this change for now and I'll try
> again with a bit more due diligence before pushing the change. Sorry
> about this.

NP, it was worth a shot :-)

> Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel