[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH V2 13/14] Infrastructure for manipulating 3-level event channel pages



On Mon, 2013-01-21 at 16:50 +0000, Jan Beulich wrote:
> >>> On 21.01.13 at 15:30, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > +    evtchn_pending = xzalloc_array(xen_pfn_t, r.nr_pages);
> > +    evtchn_mask = xzalloc_array(xen_pfn_t, r.nr_pages);
> > +    l2sel_mfns = xzalloc_array(xen_pfn_t, r.nr_vcpus);
> > +    l2sel_offsets = xzalloc_array(xen_pfn_t, r.nr_vcpus);
> 
> While the former two are okay, the latter two aren't since
> this can easily amount to an allocation of more than a page.
> This needs to be broken up.
> 

Judging from the code, the underlying _xmalloc is able to handle
situation when allocation is more than a page, isn't it?


Wei.

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.