Re: [Xen-devel] [PATCH 4/8] docs: Add some extra details to the ELF note.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-01-28 at 18:32 +0000, Konrad Rzeszutek Wilk wrote:
> Such as how they are composed (ASCII or ASCIZ).

Are any of them actually non-null terminated ASCII?

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  xen/include/public/elfnote.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/xen/include/public/elfnote.h b/xen/include/public/elfnote.h
> index 74223dd..5205c9d 100644
> --- a/xen/include/public/elfnote.h
> +++ b/xen/include/public/elfnote.h
> @@ -38,6 +38,8 @@
>   *
>   * LEGACY indicated the fields in the legacy __xen_guest string which
>   * this a note type replaces.
> + *
> + * String values (for non-legacy) are ASCIZ type.

I'd be tempted to spell this out as "NULL terminated ASCII".

>   */
>  
>  /*
> @@ -57,6 +59,7 @@
>  /* The virtual address of the hypercall transfer page (numeric).
>   *
>   * Example is 0xffffffff81001000 (but not for legacy)
> + * For LEGACY an example is 0x2

A better example (but see my comment on patch 2) would be the pfn
corresponding to the non-legacy address, which I suppose is 0x81001 or
something.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel