Re: [Xen-devel] [PATCH 3/3] xen/arch/arm: add XSM hook to HVMOP_{get, set}_param

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-01-18 at 09:19 +0000, Ian Campbell wrote:
> On Thu, 2013-01-17 at 18:55 +0000, Daniel De Graaf wrote:
> > This hook is not x86-specific; move it out of CONFIG_X86.
> > 
> > Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> 
> Looks good to me (other than diff choosing the most confusing possible
> way to represent the movement of xsm_hvm_param in xsm.h!)
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Looks like I should have actually built this one before acking...

8<--------------------------------

>From f2ec1f2cba7eab8d6c6c93378625379abe0e29bc Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Thu, 31 Jan 2013 09:14:40 +0000
Subject: [PATCH] xen: arm: fix build of hvm.c

Add include of xsm/xsm.h to fix:

hvm.c: In function 'do_hvm_op': hvm.c:37:9: error: implicit declaration of 
function 'xsm_hvm_param' [-Werror=implicit-function-declaration]
hvm.c:37:9: error: nested extern declaration of 'xsm_hvm_param' 
[-Werror=nested-externs]
hvm.c:37:28: error: 'XSM_TARGET' undeclared (first use in this function)
hvm.c:37:28: note: each undeclared identifier is reported only once for each 
function it appears in
cc1: all warnings being treated as errors

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>
---
 xen/arch/arm/hvm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index 63ac793..471c4cd 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -5,6 +5,8 @@
 #include <xen/guest_access.h>
 #include <xen/sched.h>
 
+#include <xsm/xsm.h>
+
 #include <public/xen.h>
 #include <public/hvm/params.h>
 #include <public/hvm/hvm_op.h>
-- 
1.7.9.1




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel