Re: [Xen-devel] [PATCH 05/13] xen: introduce test_and_set_mask

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2013-02-01 at 11:35 +0000, David Vrabel wrote:
> On 31/01/13 14:46, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  drivers/xen/events.c |   10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 93a3648..0fae3f9 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -345,6 +345,12 @@ static inline int test_evtchn(int port)
> >     return sync_test_bit(port, &s->evtchn_pending[0]);
> >  }
> >  
> > +static inline int test_and_set_mask(int port)
> 
> This name is too generic.  Suggest test_and_set_evtchn_mask() or similar.

For a static function inside drivers/xen/events.c that seems like
overkill.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel