Re: [Xen-devel] Is: PVH + ARM new hypercalls. Was: Re: [PATCH]: PVH: specify xen features strings cleany for PVH

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-02-01 at 19:27 +0000, Mukesh Rathor wrote:
> On Fri, 01 Feb 2013 16:24:57 +0000
> "Jan Beulich" <jbeulich@xxxxxxxx> wrote:
> 
> > >>> Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> 02/01/13 3:23 AM >>>
> > >On Tue, 29 Jan 2013 10:48:12 +0000 "Jan Beulich" <JBeulich@xxxxxxxx>
> > >wrote:
> > >> >>> On 29.01.13 at 03:57, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> > >> >>> wrote:
> > >> difficult, but I continue to see more advantage in avoiding the
> > >> redundancy).
> > >
> > >That was my patch version 2, where I called it gdt and another
> > >reviewer suggested to change to u. So I changed it to u.
> > >
> > >It's gone thru enough iterations that I'd like to leave as is. Thank
> > >you in advance for your compromise in helping us mortals grep/cscope 
> > >to learn code.
> > 
> > That's part of the reason why I said from the beginning that doing
> > the Linux side first is wrong.
> 
> It was reviewed by xen folks like Ian C, Stefano, etc... 

Well, that doesn't in any way mean that Jan's opinion isn't valid or
relevant and where reviewers/authors cannot reach consensus over
something then it is ultimately the maintainer's call.

I deliberately avoided formally Acking any of the Linux side patches
until the hypervisor side was posted and reviewed, precisely because it
is necessary to review the hypervisor interfaces as part of the
hypervisor changes before committing to them. I believe we explicitly
agreed that the interface would be subject to change when the hypervisor
patches were posted for review.

WRT this particular change I don't personally like the idea of sharing
gdt_frames[0] and gdt_ents for two semantically different usages, but I
would defer to Jan as a hypervisor maintainer on that point.

I don't much care about the gdt vs u naming for the union, although I
would probably have gone with the more meaningful gdt if it were me.
cscope-wise in emacs I would just use "C-c s t" to look for "gdt.size"
etc.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel