Re: [Xen-devel] [PATCH] tools/xc: restore logging in xc_save

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-02-04 at 10:50 +0000, Olaf Hering wrote:
> On Mon, Feb 04, Ian Campbell wrote:
> 
> > On Mon, 2013-02-04 at 10:23 +0000, Olaf Hering wrote:
> > > On Mon, Feb 04, Ian Campbell wrote:
> > > 
> > > > On Fri, 2013-02-01 at 18:58 +0000, Olaf Hering wrote:
> > > > > +    lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL;
> > > > > +    lflags = XTL_STDIOSTREAM_HIDE_PROGRESS;
> > > > 
> > > > Would it be useful (as an extension) to implement an XTL_STDIOSTREAM
> > > > flag which makes it output something more suitable for logging,
> > > > e.g. ...10%...20%...30%... 
> > > > (or perhaps automatic based on isatty(outputfd)?)
> > > 
> > > I was thinking about that, to extend the called progress functions. In
> > > the case of xend.log it would produce many lines of progress.
> > 
> > How come many lines? I imaged the above as a single line.
> 
> Oh, I did not realize that we did not talk about
> XTL_STDIOSTREAM_HIDE_PROGRESS but about another new flag.

Right, or perhaps changing the behaviour of the !HIDE_PROGRESS flag
based on isatty, which would also perhaps fix the ugliness here:
http://www.chiark.greenend.org.uk/~xensrcts/logs/15367/test-amd64-amd64-xl/11.ts-guest-localmigrate.log
(not a big deal though)

> 
> 
> > > No idea if any caller makes use of the progress, given that it did not
> > > work at all without the other patch I sent last Friday.
> > 
> > xl migrate uses AFAIK, which isn't to say it wasn't broken ;-)
> 
> For me it was not printed without the patch in
> <6d1d516ecaade56f796e.1359738924@xxxxxxxxxxxx>

I guess this is in my queue somewhere, I'll take a look.

> > Although I did mean to ask why the code had to move?
> 
> To get to si.flags.

A-ha!

Thanks,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel