Re: [Xen-devel] [PATCH 2/2] Implement code to read coverage informations

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.02.13 at 18:08, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
> +/**
> + * File information
> + * Prefixed with XENCOV_TAG_FILE and a string with filename
> + */
> +struct xencov_file
> +{
> +    uint32_t version;
> +    uint32_t stamp;
> +} __attribute__((packed));

No (unconditional) use of compiler extensions in public headers.
Even more so that you really don't need it here ...

> +
> +/**
> + * Counters information
> + * Prefixed with XENCOV_TAG_COUNTER(n) where n is 0..(XENCOV_COUNTERS-1)
> + */
> +struct xencov_counter
> +{
> +    uint32_t num;
> +    uint64_t values[0];
> +} __attribute__((packed));

... and you can easily avoid it here, and it's pointless again further
down.

The [0] btw also is a compiler extension, and hence you'll also
need to replace it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel