Re: [Xen-devel] [PATCH 1/2] xl/libxl: add netdev to vif specification

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-02-05 at 10:56 +0000, Roger Pau Monne wrote:
> >> @@ -98,6 +103,8 @@ static char **get_hotplug_env(libxl__gc *gc,
> >>      env[nr++] = GCSPRINTF("backend/%s/%u/%d", type, dev->domid, 
> >> dev->devid);
> >>      env[nr++] = "XENBUS_BASE_PATH";
> >>      env[nr++] = "backend";
> >> +    env[nr++] = "netdev";
> >> +    env[nr++] = netdev;
> > 
> > Mightn't this be NULL?
> 
> Yes, if we are using the vif-bridge script this will be NULL, but I
> prefer adding this NULL here rather than having a conditional and a
> variable array size (because we also have an assert(nr == arraysize) at
> the end of the code block).

Doesn't NULL terminate the env list? That might work right now while
this option is last but it will confuse the hell out of whoever adds the
next variable...

env[nr++] = netdev ? : "" might suffice?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel