[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/4] Check no constructor section



>>> On 05.02.13 at 16:58, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
> Safety check for initialization objects.
> Constructors are not used so check some module does not use them.

Why? They're themselves being put into .init.data, so their
presence is fine in init-only objects.

Jan

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -166,7 +166,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach n,1 2 4 
> 8,rodata.str1.$(n)) \
>  $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o Makefile
>       $(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p}' | while read idx name 
> sz rest; 
> do \
>               case "$$name" in \
> -             .text|.text.*|.data|.data.*|.bss) \
> +             .text|.text.*|.data|.data.*|.bss|.ctors) \
>                       test $$sz != 0 || continue; \
>                       echo "Error: size of $<:$$name is 0x$$sz" >&2; \
>                       exit $$(expr $$idx + 1);; \



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.