Re: [Xen-devel] [PATCH 1/4] Adding support for coverage information

[Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>]

On Wed, 2013-02-06 at 08:35 +0000, Ian Campbell wrote:
> On Tue, 2013-02-05 at 15:58 +0000, Frediano Ziglio wrote:
> > +void __init init_coverage(void)
> > +{
> > +    unsigned long n;
> > +    for ( n = 0; n < __CTOR_LIST__.count; ++n )
> > +        __CTOR_LIST__.funcs[n]();
> 
> There is nothing coverage specific here, why not run these from a
> generic function?
> 
> Ian.
> 
> 

You are right, but currently are only used for coverage and constructors
are not expected to be useful in Xen.

One more question. The __CTOR_LIST__ name and the counters before the
array it's a choice following GCC convention but there is no need to
follow it. Do you thing a better name and perhaps just the array with a
final NULL of a pointer to the end would be better?

Frediano

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel