Re: [Xen-devel] [PATCH 02/13] xen: fix error handling path if xen_allocate_irq_dynamic fails

[Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>]

On Thu, Jan 31, 2013 at 02:46:56PM +0000, Wei Liu wrote:
> It is possible that the call to xen_allocate_irq_dynamic() returns negative
> number other than -1.

Applied.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  drivers/xen/events.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 2c94aad..93a3648 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -820,7 +820,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
>  
>       if (irq == -1) {
>               irq = xen_allocate_irq_dynamic();
> -             if (irq == -1)
> +             if (irq < 0)
>                       goto out;
>  
>               irq_set_chip_and_handler_name(irq, &xen_dynamic_chip,
> @@ -923,7 +923,7 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
>  
>       if (irq == -1) {
>               irq = xen_allocate_irq_dynamic();
> -             if (irq == -1)
> +             if (irq < 0)
>                       goto out;
>  
>               irq_set_chip_and_handler_name(irq, &xen_percpu_chip,
> -- 
> 1.7.10.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel