Re: [Xen-devel] [PATCH 4/5] Check no constructor section

[Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>]

On Wed, 2013-02-06 at 15:01 +0000, Jan Beulich wrote:
> >>> On 06.02.13 at 15:32, Frediano Ziglio <frediano.ziglio@xxxxxxxxxx> wrote:
> > Safety check for initialization objects.
> > Constructors are not used so check some module does not use them.
> 
> Once again - why?
> 
> And repeating earlier complaints of mine - why do you continue to
> re-post without having addressed all comments on prior revisions
> (verbally or by changing the patches)? This is just wasting
> reviewers' time.
> 
> Jan
> 

Nothing personal, I'm just a bad mail reader. In this case I checked
mails filtering with "cover" but your reply didn't have it on the
subject.

Sometimes I search if there are courses for reading mail but strangely
there are only courses on how use use some mail products or how to write
them.

Frediano

> > Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
> > ---
> >  xen/Rules.mk |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/Rules.mk b/xen/Rules.mk
> > index 3f0b262..ae35a08 100644
> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -166,7 +166,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach n,1 2 4 
> > 8,rodata.str1.$(n)) \
> >  $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o Makefile
> >     $(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p}' | while read idx name 
> > sz rest; 
> > do \
> >             case "$$name" in \
> > -           .text|.text.*|.data|.data.*|.bss) \
> > +           .text|.text.*|.data|.data.*|.bss|.ctors) \
> >                     test $$sz != 0 || continue; \
> >                     echo "Error: size of $<:$$name is 0x$$sz" >&2; \
> >                     exit $$(expr $$idx + 1);; \
> > -- 
> > 1.7.9.5
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel