Re: [Xen-devel] [PATCH] xen-pciback: notify hypervisor about devices intended to be assigned to guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.02.13 at 18:12, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
>> +    if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) {
>> +            struct physdev_pci_device ppdev = {
>> +                    .seg = pci_domain_nr(dev->bus),
>> +                    .bus = dev->bus->number,
>> +                    .devfn = dev->devfn
>> +            };
>> +            int err = HYPERVISOR_physdev_op(PHYSDEVOP_release_msix,
>> +                                            &ppdev);
>> +
>> +            if (err)
>> +                    dev_warn(&dev->dev, "MSI-X release failed (%d)\n",
>> +                             err);
>> +    }
> 
> Perhaps it should be more off:
> 
>               if (err) {
>                       if (err == -ENOSYS)
>                               dev_info(&dev->dev,"MSI-X release
> hypercall not supported.");
>                       else
>                               dev_warn(&dev->dev, "MSI-X release failed 
> (%d)\n",
>                                        err);
>                               

Why would you want to special case this? The more that _really_
old hypervisors returned -EINVAL instead of -ENOSYS here?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel