Re: [Xen-devel] [PATCH v7] cover: Coverage support

[Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>]

On Thu, 2013-02-07 at 11:57 +0000, George Dunlap wrote:
> On 07/02/13 11:27, Frediano Ziglio wrote:
> > Updated set of patches for coverage.
> >
> > Changes:
> > - remove operation to check if coverage enabled
> > - add operation to read and reset coverage at same time
> > - updated utility to refrect changes above
> >
> 
> I've done a once-over and in principle I think this is a good series.  
> Thanks for doing it -- I think Xen has needed this for some time.  Just 
> a couple of high-level comments (and I haven't been following the 
> discussion, so please forgive me if I'm contradicting something someone 
> said somewhere else):
> 
> First, re the name -- is there any reason not to call it "gcov" (or 
> "xgcov" or something like that) in the patch series and the Xen 
> command-line option?  Since we're using the gcov format and the intent 
> (I presume) is to use the gcov tools to do the actual analysis,
> 

Do you mean gcov on first commit line? That's fine.

For the tool I used xencov like xenperf and xentrace. cov instead of
gcov allow to change the compiler in the future (I don't know,
clang/llvm perhaps?).

> Secondly, there doesn't seem to be any documentation.  A definition of 
> the Xen command-line term is an absolute minimum, and a brief markdown 
> how-to explaining how to enable the option and use it would be much 
> appreciated.
> 

You are right. I need some direction however. Which documentation are
you referring at? Wiki, internal one (docs directory in
xen-unstable.hg)?

>   -George

Frediano

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel