Re: [Xen-devel] [PATCH 11/45] xen: arm64: TLB flushes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-02-07 at 15:31 +0000, Tim Deegan wrote:
> At 15:56 +0000 on 23 Jan (1358956577), Ian Campbell wrote:
> > --- /dev/null
> > +++ b/xen/include/asm-arm/arm64/flushtlb.h
> > @@ -0,0 +1,34 @@
> > +#ifndef __ASM_ARM_ARM64_FLUSHTLB_H__
> > +#define __ASM_ARM_ARM64_FLUSHTLB_H__
> > +
> > +/* Flush local TLBs, current VMID only */
> > +static inline void flush_tlb_local(void)
> > +{
> > +    asm volatile(
> > +        "dsb sy;"
> > +        "tlbi vmalle1;" /* ,is ??? */
> 
> Good question.  I think probably not ',is'; at least not until we decide
> on, and document, what inner & outer mean on a Xen system.

Agreed, dropped the comment.

> I see that the 32-bit equivalent does use IS; I think that's proabably
> an error too.

I have sent out a patch for this.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel