Re: [Xen-devel] [PATCH v2 2/4] xl: allow specifying a default gatewaydev in xl.conf

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 15/02/13 15:06, Ulf Kreutzberg wrote:
> Hello Roger,
> hello everybody,
> 
> sorry for the late reply.
> 
> On 14.02.2013 16:17, Roger Pau Monnà wrote:
>> Could you take a look at tools/libxl/libxl_types.idl?
>>
>> You should have something like the following chunk:
>>
>> libxl_device_nic = Struct("device_nic", [
>>     ("backend_domid", libxl_domid),
>>     ("devid", libxl_devid),
>>     ("mtu", integer),
>>     ("model", string),
>>     ("mac", libxl_mac),
>>     ("ip", string),
>>     ("bridge", string),
>>     ("ifname", string),
>>     ("script", string),
>>     ("nictype", libxl_nic_type),
>>     ("rate_bytes_per_interval", uint64),
>>     ("rate_interval_usecs", uint32),
>>     ("gatewaydev", string),
>>     ])
>>
>> (With only one "gatewaydev").
>>
> That was my copy'n'paste mistake - fixed.
> 
> I could see that after applying patches V1 the parameter "netdev" is
> parsed correctly and the main ip is passed to xen scripts.
> However, I could not get xen 4.3 running so I had to test 4.3 tools on
> 4.2.1 hypervisor, which could not start the domU, but debug output of
> the scripts showed me everything is parsed as expected.
> 
> The mac address still is not parsed if digits are not padded with
> leading zero, like "mac=de:ad:a:1e:42:3" - the rest of the line is
> ignored without any error.
> 
> However, I was not able to apply patches V2 after that, they do not seem
> to work together with the first patch series.

Hello Ulf,

Version v2 should be applied without v1, they are not additional
patches, it's a revision of the same patches (trying to apply both will
lead to errors). To simplify it I've pushed the patches to my git repo,
so you can fetch them easily:

$ git clone -b vif_route_v2 git://xenbits.xen.org/people/royger/xen.git

More information about how to build Xen from source can be found at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source#Building_from_Source.

Hope this helps, Roger.

> Only patching with V2 resulted in missing "netdev" member in
> libxl_device_nic (libxl_types.idl). After editing the file and adding
> the definition, it compiled so far.
> 
> xl with only patches V2 applied does parse neither netdev nor gatewaydev
> as it seems.
> 
> 
> Best regards,
> Ulf
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel