[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] xen: arm: create dom0 DTB /hypervisor/ node dynamically.



On Tue, 2013-02-05 at 11:26 +0000, Anthony PERARD wrote:
> > +    /*
> > +     * Sanity-check address sizes, since addresses and sizes which do not 
> > take
> > +     * up exactly 4 or 8 bytes are not supported.
> > +     */
> > +    if ((addrcells != 1 && addrcells != 2) ||
> > +        (sizecells != 1 && sizecells != 2))
> > +        panic("Cannot cope with this size");
> 
> You could add those two properties in the hypervisor node if they don't
> match what we expect them to be. This would avoid panicking with a
> device tree that have different default values.

Unfortunately the #address-cells nodes etc affect only the children of
the current node. The sizes for this node are controlled by the parent's
sizes.

In practice #address-cells more than 2 (i.e. using 16 or more bytes)
seem like they are going to be rather rare.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.