Re: [Xen-devel] [PATCH] mini-os: implement poll(2)

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Also, checking for files[i].type should be done on entry to the
function, not after having waited for some time (and perhaps opened some
file descriptor, etc.). I.e.:

Wei Liu, le Tue 19 Feb 2013 15:54:13 +0000, a écrit :
> +        /* ignore invalid fds */
> +        if (fd < 0 || fd >= NOFILE)
> +            continue;

record POLLNVAL as soon as here, and ignore that fd later on.

> +    /* don't care about the return value, but we do need errno */
> +    select(max_fd+1, &rfds, &wfds, &efds, timeo);

Mmm. I don't think we don't care about the return value: if select
returns -1 with EINTR, poll has to do the same. That's however probably
the only case we have to take care of.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel