Re: [Xen-devel] [PATCH V2 27/46] xen: arm: arm64 trap handling.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-02-21 at 16:07 +0000, Tim Deegan wrote:
> At 16:02 +0000 on 21 Feb (1361462564), Ian Campbell wrote:
> > On Thu, 2013-02-21 at 15:36 +0000, Tim Deegan wrote:
> > > At 15:25 +0000 on 21 Feb (1361460324), Ian Campbell wrote:
> > > > On Thu, 2013-02-21 at 15:10 +0000, Tim Deegan wrote:
> > > > > At 16:47 +0000 on 14 Feb (1360860461), Ian Campbell wrote:
> > > > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > > > > ---
> > > > > > v2: Call leave_hypervisor_tail on exit back to guest, disable 
> > > > > > interrupts while
> > > > > >     restoring state.
> > > > > 
> > > > > You don't seem to have addressed my other comments on v1:
> > > > 
> > > > I've got them in v3, I noted that I hadn't addresses you comment on this
> > > > patch in the #0/46.
> > > 
> > > So you did; I did read the 0/46, but for some reason all that stuck in
> > > my head was the WFE stuff. 
> > > 
> > > AFAICS you just need to re-roll this and #25,
> > 
> > I don't think you mean #25? That is "xen: arm64: add guest type to
> > domain field." which you've acked.
> 
> Sorry, I meant #5.

Ah yes, I've just resent that one.

> > When I'm applying my own patches I prefer to do it from the list rather
> > than short cutting them from my own tree, keep me honest/from making
> > mistakes. How about I include an index of acked/unacked patches in the
> > zeroeth mail? You ought to be able to just mark it all as read.
> 
> Fair enough -- no need to index them; I just keep all previous versions
> of a series around so I can easily find the comments.  But this won't
> need a v4, will it? :)

I hope not!

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel