Re: [Xen-devel] [PATCH] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2013-02-23 at 20:47 +0000, Stefano Stabellini wrote:
> On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote:
> > On Sat, Feb 23, 2013 at 09:03:20AM -0800, Kees Cook wrote:
> > > On Sat, Feb 23, 2013 at 3:59 AM, Dongsheng Song
> > > <dongsheng.song@xxxxxxxxx> wrote:
> > > > On Sat, Feb 23, 2013 at 3:29 PM, Kees Cook <keescook@xxxxxxxxxxxx> 
> > > > wrote:
> > > >>
> > > >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
> > > >> while now and is almost always enabled by default. As agreed during the
> > > >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs.
> > > >>
> > > >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > > >> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > >> Cc: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> > > >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > > >> ---
> > > >>  arch/x86/xen/Kconfig |    2 +-
> > > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > > >> index 93ff4e1..8cada4c 100644
> > > >> --- a/arch/x86/xen/Kconfig
> > > >> +++ b/arch/x86/xen/Kconfig
> > > >> @@ -53,7 +53,7 @@ config XEN_DEBUG_FS
> > > >>
> > > >>  config XEN_X86_PVH
> > > >>         bool "Support for running as a PVH guest (EXPERIMENTAL)"
> > > >
> > > > Why not remove this 'EXPERIMENTAL' too ?
> > > 
> > > It was unclear to me if the feature was actually considered unstable.
> > > I can resend with the text removed from the title too, if that's the
> > > correct action here?
> > 
> > It certainly is unstable right now (which is why it was unstaged from
> > the v3.9 train). I hope that by v3.10 it won't be - at which
> > point this patch (and the EXPERIMENTAL) makes sense.
> > 
> > So could you respin it please with the text removed as well - and I will
> > queue it up in the branch that carries the PVH feature?
> 
> We also have the same flag on Xen ARM, and the reason is that the ABI is
> not stable yet. As soon as it is (I think soon now), I'll send a patch
> to remove EXPERIMENTAL from there too.

In the meantime if the depends EXPERIMENTAL is going away perhaps we
should explain the EXPERIMENTAL in the title:

8<----------------------------------------------------

>From bc22bd0f7b20296c449a05d82be950922042bc92 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Thu, 4 Oct 2012 09:12:51 +0100
Subject: [PATCH] arm: xen: explain the EXPERIMENTAL dependency in the Kconfig 
help

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
---
 arch/arm/Kconfig |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 67874b8..ef14873 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1865,6 +1865,14 @@ config XEN
        help
          Say Y if you want to run Linux in a Virtual Machine on Xen on ARM.
 
+
+         This option is EXPERIMENTAL because the hypervisor
+         interfaces which it uses are not yet considered stable
+         therefore backwards and forwards compatibility is not yet
+         guaranteed.
+
+         If unsure, say N.
+
 endmenu
 
 menu "Boot options"
-- 
1.7.2.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel