Re: [Xen-devel] [PATCH] libxl: Made it possible to use 'timer='delay_for_missed_ticks'

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-02-25 at 16:33 +0000, Konrad Rzeszutek Wilk wrote:
> The assertion only allows values of 1 (no_delay_for_missed_ticks)
> up to 3 (one_missed_tick_pending). It should be possible to
> use the value of 1 (delay_for_missed_ticks) for the timer configuration
> option.

Doh! That was very likely a brainfart by me...

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.cambell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_dom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index e1cd9a4..de555ee 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -417,7 +417,7 @@ out:
>  static unsigned long timer_mode(const libxl_domain_build_info *info)
>  {
>      const libxl_timer_mode mode = info->u.hvm.timer_mode;
> -    assert(mode != LIBXL_TIMER_MODE_DELAY_FOR_MISSED_TICKS &&
> +    assert(mode >= LIBXL_TIMER_MODE_DELAY_FOR_MISSED_TICKS &&
>             mode <= LIBXL_TIMER_MODE_ONE_MISSED_TICK_PENDING);
>      return ((unsigned long)mode);
>  }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel