Re: [Xen-devel] [PATCH] credit: track residual from divisions done during accounting

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 02/26/2013 03:07 PM, Jan Beulich wrote:
> > > > On 26.02.13 at 16:00, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > On 02/18/2013 12:37 PM, Jan Beulich wrote:
> > > This should help with under-accounting of vCPU-s running for extremly
> > > short periods of time, but becoming runnable again at a high frequency.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > The changes to credit1 look good, and I'm fine with a patch having those
> > (and a commented ASSERT) go in.
> >
> > Credit2 I'm not so happy with, because the names "t2c" and "c2t" imply
> > (at least to me) that they are only converting, not changing anything;
> > particularly in the way that t2c is called.  At the moment everything
> > will work fine, but it's just laying a trap for someone in the future. :-)
> >
> > I've got a patch in my queue dealing with this section already -- why
> > don't you apply just the sched_credit.c part of the patch, and I'll take
> > the credit2 part of your patch and rework it so it satisfies me.
> That's fine with me of course.
>
> May I take the above as a pre-ack to a patch modified accordingly?
Yes, I suppose that's fine. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel