Re: [Xen-devel] [PATCH V3] vmx/nmi: Do not use self_nmi() in VMEXIT handler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.02.13 at 14:00, Tim Deegan <tim@xxxxxxx> wrote:
> commit d278beed1df2d226911dce92295411018c9bba2f
> Author: Tim Deegan <tim@xxxxxxx>
> Date:   Thu Feb 28 12:42:15 2013 +0000
> 
>     vmx: handle NMIs before re-enabling interrupts.
>     
>     Also, switch to calling do_nmi() and explicitly re-enabling NMIs
>     rather than raising a fake NMI and relying on the NMI processing to
>     IRET, since that handling code is likely to change a fair amount in
>     future.

Isn't that a gross understatement, considering that you or Malcolm
had found that the use of self_nmi() here was actively broken?

>     Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

(realizing that dealing with the PV side of the issue will be left to
me in the end)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel