Re: [Xen-devel] [PATCH v2] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL

[Kees Cook <keescook@xxxxxxxxxxxx>]

On Thu, Feb 28, 2013 at 2:53 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 28 Feb 2013, Kees Cook wrote:
>> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
>> while now and is almost always enabled by default. As agreed during the
>> Linux kernel summit, remove it from any "depends on" lines in Kconfigs.
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> Cc: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> ---
>>
>> v2:
>>  - drop EXPERIMENTAL from bool and help text too.
>>
>> ---
>>  arch/x86/xen/Kconfig |    8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>> index 93ff4e1..6c5802f 100644
>> --- a/arch/x86/xen/Kconfig
>> +++ b/arch/x86/xen/Kconfig
>> @@ -52,12 +52,10 @@ config XEN_DEBUG_FS
>>         Enabling this option may incur a significant performance overhead.
>>
>>  config XEN_X86_PVH
>> -     bool "Support for running as a PVH guest (EXPERIMENTAL)"
>> -     depends on X86_64 && XEN && EXPERIMENTAL
>> +     bool "Support for running as a PVH guest"
>> +     depends on X86_64 && XEN
>>       default n
>>       help
>>          This option enables support for running as a PVH guest (PV guest
>>          using hardware extensions) under a suitably capable hypervisor.
>> -        This option is EXPERIMENTAL because the hypervisor interfaces
>> -        which it uses is not yet considered stable therefore backwards and
>> -        forwards compatibility is not yet guaranteed.  If unsure, say N.
>> +        If unsure, say N.
>
> Please do not change the text this way.
> The fact that CONFIG_EXPERIMENTAL is going away it doesn't change the
> fact that this feature is experimental.
> Maybe you want to replace EXPERIMENTAL with experimental, or if
> experimental has become as taboo word, I am sure you can find a suitable
> synonym.

Ah, sorry, I misunderstood what was being recommended from the other
thread (quoting below...)

On Sat, 23 Feb 2013, Konrad Rzeszutek Wilk wrote:
> It certainly is unstable right now (which is why it was unstaged from
> the v3.9 train). I hope that by v3.10 it won't be - at which
> point this patch (and the EXPERIMENTAL) makes sense.

Only "depends on EXPERIMENTAL" must go away. Did you want either the
bool or help text to go away too? If neither, my original patch should
work. If you only want the bool text gone, I can send that version
instead.

-Kees

--
Kees Cook
Chrome OS Security

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel