Re: [Xen-devel] suspicious shift in compat_memory_op()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.03.13 at 12:30, Xi Wang <xi@xxxxxxx> wrote:
> xen/common/compat/memory.c:175
> 
>   if ( order_delta >= 0 )
>       nat.xchg->out.nr_extents = end_extent >> order_delta;
>   else
>       nat.xchg->out.nr_extents = end_extent << order_delta;
> 
> Shifting a negative "order_delta" doesn't make much sense.
> 
> Should it be something like "end_extent << -order_delta"?  Thanks.

Yes, absolutely. Thanks for pointing this out!

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel