Re: [Xen-devel] [PATCH] x86: reduce irq_cpustat_t's __softirq_pending to 32 bits

[Keir Fraser <keir@xxxxxxx>]

On 01/03/2013 16:11, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> Assembly code was already only accessing the low 32 bits of it, and
> we're far away from using all 32 bits of it.
> 
> Noticed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I'd also be fine with some explicitly-sized typing here. But I don't really
care much about that either way, so:

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/include/asm-x86/hardirq.h
> +++ b/xen/include/asm-x86/hardirq.h
> @@ -5,7 +5,7 @@
>  #include <xen/cache.h>
>  
>  typedef struct {
> - unsigned long __softirq_pending;
> + unsigned int __softirq_pending;
> unsigned int __local_irq_count;
> unsigned int __nmi_count;
> bool_t __mwait_wakeup;
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel