[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Xen/ACPI: support sleep state entering on hardware reduced systems



>>> On 11.03.13 at 15:51, "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> On Monday, March 11, 2013 02:06:51 PM Jan Beulich wrote:
>> In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with
>> reduced hardware sleep support, and the two changes didn't get
>> synchronized: The new code doesn't call the hook function (if so
>> requested). Fix this, requiring a boolean parameter to be added to the
>> hook function to distinguish "extended" from "legacy" sleep.
>> 
>> This requires adjusting TXT, but the adjustments only go as far as
>> failing the extended mode call (since, looking at the TXT interface,
>> there doesn't even appear to be precautions to deal with that
>> alternative interface).
>> 
>> The hypervisor change underlying this is commit 62d1a69 ("ACPI: support
>> v5 (reduced HW) sleep interface") on the master branch of
>> git://xenbits.xen.org/xen.git.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Richard L Maliszewski <richard.l.maliszewski@xxxxxxxxx>
>> Cc: Gang Wei <gang.wei@xxxxxxxxx>
>> Cc: Shane Wang <shane.wang@xxxxxxxxx>
>> ---
>> v2: Extend description to include reference to hypervisor side change.
>> 
>> ---
>>  arch/x86/kernel/tboot.c          |    6 +++++-
>>  drivers/acpi/acpica/hwesleep.c   |    8 ++++++++
>>  drivers/acpi/acpica/hwsleep.c    |    2 +-
>>  drivers/acpi/osl.c               |   16 ++++++++--------
>>  drivers/xen/acpi.c               |   26 +++++++++++++-------------
>>  include/linux/acpi.h             |   10 +++++-----
>>  include/xen/acpi.h               |    4 ++--
>>  include/xen/interface/platform.h |    7 ++++---
>>  8 files changed, 46 insertions(+), 33 deletions(-)
> 
> ACPICA changes (hwesleep.c and hwsleep.c) need to go separately and through 
> the
> upstream ACPICA before we can take them into the kernel.  Sorry about that.

Looking at 09f98a8 (the change originally introducing the hook)
and comparing with the rest of the changes to hwsleep.c, I would
think this one didn't come from the ACPICA tree either.

But anyway - if I really need to do that, are there any pointers as
to where to submit this to, and how to make sure it gets picked up
rather sooner than later?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.