Re: [Xen-devel] [PATCH 11/18 V2]: PVH xen: some misc changes like mtrr, intr, msi.

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 16.03.13 at 01:46, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -693,6 +696,13 @@ uint8_t epte_get_entry_emt(struct domain *d, unsigned 
> long gfn, mfn_t mfn,
>           ((d->vcpu == NULL) || ((v = d->vcpu[0]) == NULL)) )
>          return MTRR_TYPE_WRBACK;
>  
> +    /* PVH: fixme/help: do I have this correct? */
> +    if ( is_pvh_domain(d) ) {
> +        if (direct_mmio)
> +            return MTRR_TYPE_UNCACHABLE;
> +        return MTRR_TYPE_WRBACK;

I don't think you can reasonably reduce a guest to just 2 memory
types, particularly not Dom0.

> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -787,10 +787,15 @@ static int msix_capability_init(struct pci_dev *dev,
>  
>      if ( !dev->msix_used_entries )
>      {
> -        if ( rangeset_add_range(mmio_ro_ranges, dev->msix_table.first,
> +        /* PVH: this is temporary only until linux msi.c is fixed. See 
> xen-devel
> +         * thread: "[PVH]: Help: msi.c".
> +         */
> +        if ( !is_pvh_domain(dev->domain) &&
> +             rangeset_add_range(mmio_ro_ranges, dev->msix_table.first,
>                                  dev->msix_table.last) )
>              WARN();
> -        if ( rangeset_add_range(mmio_ro_ranges, dev->msix_pba.first,
> +        if ( !is_pvh_domain(dev->domain) &&
> +             rangeset_add_range(mmio_ro_ranges, dev->msix_pba.first,
>                                  dev->msix_pba.last) )
>              WARN();
>  

As already said before, the whole change above has my explicit
NAK.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel