Re: [Xen-devel] [PATCH 4/18 V2]: PVH xen: add params to read_segment_register

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Mon, 18 Mar 2013 11:44:29 +0000
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 16.03.13 at 01:28, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > --- a/xen/arch/x86/traps.c
> > +++ b/xen/arch/x86/traps.c
> > @@ -1823,7 +1823,7 @@ static inline uint64_t
> > guest_misc_enable(uint64_t
> > val) }
> > \ (eip) += sizeof(_x); _x; }) 
> > -#define read_sreg(regs, sr) read_segment_register(sr)
> > +#define read_sreg(vcpu, regs, sr) read_segment_register(vcpu,
> > regs, sr)
> 
> I don't see why you would need to retain this macro now that all
> arguments get simply passed through.

I figured they didn't use read_segment_register() in the first place,
so may be will need to be changed again in future. I'll just get rid of
it then and use read_segment_register().

thanks
m

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel