Re: [Xen-devel] [PATCH] ACPI/APEI: revert "accept validly sized ERST on Intel systems only for now"

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/03/2013 09:26, Jan Beulich wrote:
> With the recent two fixes to ERST handling, this should no longer be
> necessary.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

There are still no failures from our regression testing, so a tentative

Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> --- a/xen/drivers/acpi/apei/erst.c
> +++ b/xen/drivers/acpi/apei/erst.c
> @@ -738,19 +738,6 @@ static int __init erst_check_table(struc
>  
>       switch (erst_tab->header_length) {
>       case sizeof(*erst_tab) - sizeof(erst_tab->header):
> -#ifdef CONFIG_X86
> -             /* XXX
> -              * While the rest of the ERST code appears to work on Intel
> -              * systems with properly sized tables, various AMD systems
> -              * appear to get hung (at boot time) by allowing this. Until
> -              * someone with access to suitable hardware can debug this,
> -              * disable the rest of the code by considering this case
> -              * invalid.
> -              */
> -             if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> -                     return -EINVAL;
> -             /* fall through */
> -#endif
>       /*
>        * While invalid per specification, there are (early?) systems
>        * indicating the full header size here, so accept that value too.
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel