Re: [Xen-devel] [PATCH 1/6] xc: use XENMEM_claim_pages hypercall during guest creation.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH 1/6] xc: use XENMEM_claim_pages hypercall 
during guest creation."):
> We add an extra parameter to the structures passed to the
> PV routine (arch_setup_meminit) and HVM routine (setup_guest)
> that determines whether the claim hypercall is to be done.

This looks plausible to me, except that you seem to have missed a
comment of Ian Campbell's on the hypercall buffers.

> +int xc_domain_claim_pages(xc_interface *xch,
> +                               uint32_t domid,
> +                               unsigned long nr_pages)
> +{
> +    int err;
> +    struct xen_memory_reservation reservation = {
> +        .nr_extents   = nr_pages,
> +        .extent_order = 0,
> +        .mem_flags    = 0, /* no flags */
> +        .domid        = domid
> +    };
> +
> +    set_xen_guest_handle(reservation.extent_start, HYPERCALL_BUFFER_NULL);

In response to which Ian C wrote in
<1363170195.32410.124.camel@xxxxxxxxxxxxxxxxxxxxxx>:

   This is unused? I think you just need:
     set_xen_guest_handle(reservation.extent_start,HYPERCALL_BUFFER_NULL);
   and drop the declaration of the bounce above.

   (personally I think a new arg struct for this subop would have been
   more obvious than forcing it into the reservation struct, but
   what's done is done)

   thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel