Re: [Xen-devel] [PATCH 4/8] kexec: add infrastructure for handling kexec images

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.04.13 at 20:59, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> +        ret = kimage_add_page(image, page_to_mfn(page) << PAGE_SHIFT);

Constructs like this aren't portable. You ought to use
page_to_maddr(), and have the called function have paddr_t
instead of unsigned long as the respective parameter.

> +    struct page_list_head unuseable_pages;

unusable_pages.

Also there appear to be a few hard tabs here and there.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel