Re: [Xen-devel] [PATCH 2/4] VMX: Turn on posted interrupt bit in vmcs

["Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>]

Keir Fraser wrote on 2013-04-09:
> On 09/04/2013 09:23, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>>>>> On 09.04.13 at 08:01, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>>> +static void posted_interrupt_handler(struct cpu_user_regs *regs)
>>> +{
>>> +    ack_APIC_irq();
>>> +    perfc_incr(ipis);
>>> +    this_cpu(irq_count)++;
>>> +}
>> 
>> If I'm not mistaken, there's no further code being added to this
>> interrupt handler in the subsequent patches. What's the point
>> for the separate interrupt then? I.e. is there any reason not to
>> reuse event_check_interrupt() and EVENT_CHECK_VECTOR?
> 
> The new POSTED_INTERRUPT_VECTOR has special behaviour when delivered in
> vmx non-root mode, so it has to be distinct from the EVENT_CHECK_VECTOR.
> Still, it could share event_check_interrupt() -- there is no need at all
> for posted_interrupt_handler() to exist.
Yes, we can share event_check_interrupt() but cannot reuse EVENT_CHECK_VECTOR 
since they have different meanings.

Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel