[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/2] xl: Add commands for usb hot-plug



On 17/04/13 11:15, Ian Campbell wrote:
On Wed, 2013-04-17 at 11:02 +0100, Roger Pau Monnà wrote:

+#define is_dec(_c) ((_c) >= '0' && (_c) <= '9')
+#define is_hex(_c) (is_dec(_c) || ((_c) >= 'a' && (_c) <= 'f'))
This are kind of general macros, that could be used elsewhere, might be
suitable to put them outside of this function and name them CHAR_IS_DEC
and CHAR_IS_HEX.
ctype.h already provides isdigit() and isxdigit(), no need for our own.
IMHO.

Oh right -- sorry, when I was looking at these I didn't see isxdigit(). That's much better.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.