Re: [Xen-devel] [PATCH v4 1/2] libxl: Introduce functions to add and remove USB devices to an HVM guest

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [PATCH v4 1/2] libxl: Introduce functions to add and 
remove USB devices to an HVM guest"):
> On 17/04/13 10:48, Roger Pau Monne wrote:
> > libxl__xs_rm_checked will not return an error if xs_rm errno is ENOENT,
> > it will only return an error if something really bad happened.
> 
> OK -- well, if you look at that whole function, there are dozens of 
> things removed and added with no checking.  I think it's 
> counter-productive to add checking in only one place -- it gives people 
> the impression that this is something new and different, when in fact 
> it's exactly the same as everything else.

Personally I think it's more important not to add new bugs, than to
avoid possibly confusing future readers of the code.  It's true that
we haven't gone through everywhere and fixed this up, but I think that
new code should be correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel