Re: [Xen-devel] [PATCH v2 5/5] VMX: Use posted interrupt to deliver virutal interrupt

["Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>]

Jan Beulich wrote on 2013-04-17:
>>>> On 17.04.13 at 08:51, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>> @@ -132,9 +135,10 @@ void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec,
> uint8_t trig)
>>      if ( hvm_funcs.update_eoi_exit_bitmap )
>>          hvm_funcs.update_eoi_exit_bitmap(target, vec, trig);
>> -    /* We may need to wake up target vcpu, besides set pending bit here */
>> -    if ( !vlapic_test_and_set_irr(vec, vlapic) )
>> -        vcpu_kick(target);
>> +    if ( hvm_funcs.deliver_posted_intr )
>> +        hvm_funcs.deliver_posted_intr(target, vec);
>> +    else if ( !vlapic_test_and_set_irr(vec, vlapic) )
>> +        vcpu_kick(vlapic_vcpu(vlapic));
> 
> Why can't that remain to be
> 
>         vcpu_kick(target);
Right..

Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel